hi.

i don't understand everything of the protocol selection.

SCARD_PROTOCOL_ANY could be replaced by
        SCARD_PROTOCOL_T0 | SCARD_PROTOCOL_T1.
why the different value with extra handling ?

"Preferred" is missleading: it's not a preference, it an absolute
requirement. "one of these or none" does the code.

muscle has no preference of it's own ?
if the app doesn't care about the procotol, and the card does both,
then muscle will take whatever is default at that time.

if the PTS failes, then T=0 / T=1 is returned, but it was not preferred.
why isn't this an error ? also PTS doesn't change rContext->dwProtocol,
but after some successfull PTS rContext->dwProtocol is returned
(at least in the T1 -> T0 case).

in SCardConnect: the test for (rContext->dwPrortotol == -1) should be
done in both cases (at least to get wiered errors that happen if
ucAvailable =0 (happens when i forget to plugin my token)).

also, what about changeing rContext->dwProtocol within PHSetProtocol,
and return only SUCCESS/FAILURE ?

i think the code could be much simpler, but i'm not 100% sure.

what is the use of the PROTOCOL_RAW ?
and why at is the use of the g_rgSCard*Pci structures,
and the defines SCARD_PCI_T0/T1/RAW ?
SCARD_PCI_T1 is used in utils/formaticc, but that's it ?
btw: utils/formaticc doesn't use PROTOCOL_ANY,
but used PROTOCOL_T0 | PROTOCOL_T1 ...

regards, andreas

----- End forwarded message -----

-- 
***************************************************************
Unix Smart Card Developers - M.U.S.C.L.E.
(Movement for the Use of Smart Cards in a Linux Environment)
http://www.linuxnet.com/
To unsubscribe send an email to majordomolinuxnet.com with
unsubscribe sclinux
***************************************************************

• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]