OSEC

Neohapsis is currently accepting applications for employment. For more information, please visit our website www.neohapsis.com or email hr@neohapsis.com
 
Re: [Muscle] BUG in PKCS11 module p11x_slot.c (Doesn't manage more than one reader correctly)

From: Chris Osgood (sclinuxfunctionalfuture.com)
Date: Wed Feb 23 2005 - 09:54:05 CST

On Tue, 2005-02-22 at 22:34 +0100, Ludovic Rousseau wrote:
> This function is already patched in the CVS version (commited 4 weeks
> ago). The patch is:
>
> Index: p11x_slot.c
> ===================================================================
> RCS file: /cvsroot/muscleapps/PKCS11/src/p11x_slot.c,v
> retrieving revision 1.31
> retrieving revision 1.32
> diff -u -p -r1.31 -r1.32
> --- p11x_slot.c 28 Nov 2004 14:30:32 -0000 1.31
> +++ p11x_slot.c 22 Jan 2005 16:05:39 -0000 1.32
> -882,9 +882,12 CK_RV slot_DisconnectSlot(CK_ULONG slotI
> while (session_l)
> {
> if (session_l->session.slotID == slotID)
> + {
> session_FreeSession(session_l);
> -
> - session_l = st.sessions;
> + session_l = st.sessions;
> + }
> + else
> + session_l = session_l->next;
> }
>
> object_FreeAllObjects(slotID, st.slots[slotID - 1].objects);
>
>
> It looks similar to the patch you propose but since it is your code and
> not mine could you confirm that this patch is also correct?

Yes, that looks like it is essentially the same thing. Slightly less
efficient but it should be fine.

--
// Chris

_______________________________________________
Muscle mailing list
Musclelists.musclecard.com
http://lists.drizzle.com/mailman/listinfo/muscle