Neohapsis is currently accepting applications for employment. For more information, please visit our website www.neohapsis.com or email email@example.com
Re: [Muscle] Patch for PCSC shim for Solaris SCF (winscard_scf.c)
From: Ludovic Rousseau (ludovic.rousseaugmail.com)
Date: Mon Oct 17 2005 - 08:23:22 CDT
On 05/10/05, Najam Siddiqui <nsiddiquiaxalto.com> wrote:
> The patch addresses the following.
> 1. Fixes bug in SCardGetStatusChange where Context index was being used
> instead of Reader index, it worked only when there was just one context.
> 2. Adds cleanup code to SCardUnload.
> 3. Changes isOCFServerRunning(.) because of memory leak issues in
> libsmartcard.so on Solaris 8, everytime SCF_Session_getSession -
> SCF_Session_close is called libsmartcard leaks memory.
I don't think you patch is the correct solution. I would prefer to see
the correction in libsmartcard.so.
Patch rejected for now.
> 4. Fix issue where SCardGetStatusChange returns incorrect status when it is
> called right after SCardEstablishContext the first time after the
> libpcsclite.so is loaded in memory, the fix is to make PCSC_Initialize()
> wait till OCF has been initialized and the internal states are consistent.
I do not understand why you do not just use:
absTime.tv_sec = currTime.tv_sec + 2;
absTime.tv_nsec = currTime.tv_usec*1000;
to convert a struct timeval in a struct timespec.
Since I do not have a Solaris machine to test and because I changed
your code a bit, the code may not even compile anymore.
So please test the SVN version and tell me if it is OK or not.
Dr. Ludovic Rousseau
For private mail use ludovic.rousseaufree.fr and not "big brother" Google
Muscle mailing list