OSEC

Neohapsis is currently accepting applications for employment. For more information, please visit our website www.neohapsis.com or email hr@neohapsis.com
 
Re: My new fdisk(8) program.

From: Thierry Deval (thierrydeval.be)
Date: Mon Feb 02 2004 - 04:06:39 CST


Hi,

By curiosity, I glanced over the code and...
- No interactive mode ?
- Why not use getopt(3) for the arguments parsing ?
- Your usage formatting is, hmm, non-intuitive...

And what's this license ? Is it supposed to be BSD-like ?
/*
  *
  * Copyright (c) 2004 Plan B
  * All Rights Reserved.
  *
  * Permission to use, copy, modify and distribute this software and its
  * documentation is hereby granted, provided that both the copyright
  * notice and this permission notice appear in all copies of the
  * software, derivative works or modified versions, and any portions
  * thereof, and that both notices appear in supporting documentation.
  *
  * Plan B ALLOWS FREE USE OF THIS SOFTWARE IN ITS "AS IS"
  * CONDITION. PLAN B DISCLAIMS ANY LIABILITY OF ANY KIND FOR
  * ANY DAMAGES WHATSOEVER RESULTING FROM THE USE OF THIS SOFTWARE.
  *
  * PLAN B requests users of this software to return to
  *
  * Slick
  * Plan B
  * Montreal, Quebec
  * plan_bvideotron.ca
  *
  */

This is small, yes, but there is room for improvement, I think...
[hint: try to stick to what's in fdisk(8)]

On Feb 2, 2004, at 05:11, slick wrote:
> Hi,
> I decided to write a new fdisk(8) program for unix. The main goal was
> to be
> able to do all the MBR manipulation from the command line, to be
> portable
> across all unix platform using libc, to work alone, to be as small and
> simple as possible and to be easy to maintain and extend.