From: David Gwynne (lokianimata.net)
Date: Tue Aug 03 2004 - 22:39:18 CDT

• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

These patches bring ohci bring our driver back up to the same level as
netbsd.

As always, feedpack please.

DG

http://www.animata.net/~loki/openbsd/usb/001-ohci-actlen.patch
from netbsd, ohci.c 1.141
log message:
Update actlen even in the case where a TD returns an error -- this is
critical for the umass bulk-only STALL case.

http://www.animata.net/~loki/openbsd/usb/002-ohci-masks.patch
from netbsd, ohci.c 1.142 1.147
log message for 1.142:
Fix a done list handling bug which exhibits under high shared interrupt
rate and bus traffic. As the interrupt register is read after checking
hcca_done_head, there was a small chance of dropping a done list.
Ignore OHCI_WDH interrupt bit if hcca_done_head is zero so that OHCI_WDH
is processed later.

log message for 1.147:
Failure to properly mask off UE_DIR_IN from the endpoint address was
causing OHCI_ED_FORMAT_ISO and EHCI_QH_HRECL to get set spuriously,
causing rather interesting lossage.

http://www.animata.net/~loki/openbsd/usb/003-ohci-reorder.patch
from netbsd, ohci.c 1.150
log message:
wap the order that two items are written; possibly fixes a race
condition that would affect isoc transfers.

http://www.animata.net/~loki/openbsd/usb/004-ohci-xfer_cleanup.patch
from netbsd, ohci.c 1.151
log message:
Avoid touching the xfer after calling usb_transfer_complete(), as the
driver callback may have recycled it. From PR 25960.

http://www.animata.net/~loki/openbsd/usb/005-ohci-cleanups.patch
from netbsd, ohci.c 1.140, 1.143, 1.148, 1.149, 1.150
log message for 1.140:
Function names printed in debug messages did not always match the
actual name of the function.

log message for 1.143:
Remove assigned-to but otherwise unused variables.
Remove unreachable break after return statements.

log message for 1.148:
Adjust a couple of comments to make it clear WTF is going on.

log message for 1.149:
Make one message dependent on ohcidebug, so it doesn't interfere with polled
operation; e.g. when entering a root device or in DDB.

log message for 1.150:
Fix an error in a printf() format.

• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]