From: Aleksander Piotrowski (aleksander.piotrowskinic.com.pl)
Date: Thu Sep 22 2005 - 02:10:03 CDT

• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

Simon Dassow <janusarea319.de> wrote:

> Now for real and with the bits attached...

So, you sent us following ports:

./devel/p5-Class-Accessor

- We already have it, please as maintainer to update this port or
  send us (and him too) an update

./devel/p5-Module-Build

- We already have it, please as maintainer to update this port or
  send us (and him too) an update

./devel/p5-Module-Pluggable-Fast

- COMMENT shouldn't start with an "a"
- Please use MASTER_SITE similar to other perl ports (i.e. don't use
  "by-authors" in it). It looks like simple ...=Module/} works fine
- Are you sure that LIB_DEPENDS is needed?
- If it's pure perl code (no shared modules, etc.) then please add
  PKG_ARCH=*
- Looks like regression tests need p5-Test-Pod(-Coverage), so please add
  proper REGRESS_DEPENDS
 
./devel/p5-Path-Class

- Same comments as above. Maybe only REGRESS_DEPENDS is not needed.

./devel/p5-Tree-Simple-VisitorFactory

- Same as above
- Also, try to regenerate PLIST (make plist)

./textproc/p5-Text-ASCIITable

- Similar problems like before.

./www/p5-Catalyst

- Running regression tests give me this:

[...]
2 tests skipped.
Failed 23/25 test scripts, 8.00% okay. 360/360 subtests failed, 0.00% okay.

Is it OK?

So, nice work but you have to fix one or two things before these ports
will be commited.

Cheers,

Alek
--
- Co do Beckhama, to gdy patrzê na te jego szaty, rzemyki, kolczyki.
Powinien jeszcze piórko w dupê wsadziæ. Jest jak panienka.
 -- Jan Nowicki, wywiad w Fakt

• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]