From: Aleksander Piotrowski (aleksander.piotrowskinic.com.pl)
Date: Fri Sep 30 2005 - 04:54:36 CDT

• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

Vladimir Támara Pati?o <vtamarainformatik.uni-kl.de> wrote:

> I wanted to share this port. I must say that I don't like the license of
> sword.

A few comments:

- please remove all those unnecessary comments from the begining from
  Makefile
- we use $OpenBSD$ and not $Id$
- check other ports how LIB_DEPENDS should be used
- use ${INSTALL_*} instead of cp in install target
- is V var really needed? It's used only once, right?
- are you sure that you are using -current system? pkg/COMMENT? ${WWW}
  and the ond of pkg/DESCR?!
- please don't hardcode /usr/local in pkg/DESCR. Anyway, I'm not sure
  if that comment about adding export to .profile should be in pkg/DESCR

Cheers,

Alek
--
Dolsilwa kl±³ szpetnie [...] Nauczy³ siê tego na Zachodzie, gdzie
przekleñstwa mia³y charakter szczególny. Mianowicie mieszkañcy [...]
przekleñstwami zniechêcali bogów do wszelakich ingerencji w bieg spraw
[...] Nie pomaga³o oczywi¶cie, lecz klêli jak nikt na ca³ym ¶wiecie.

• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]