From: Douglas Santos (dsantoshydroxyl.org)
Date: Sun Oct 02 2005 - 22:40:06 CDT

• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

On Sun, 2005-10-02 at 13:00 +0200, Aleksander Piotrowski wrote:
> Douglas Santos <dsantoshydroxyl.org> wrote:
>
> > openct-0.6.6
>
> - don't hardcode /usr/local in Makefile (use ${LOCALBASE})

OK.

> - please check other ports and see if they have # Uses pthreads comment.
> Do they?

Some have..
# grep -r "Uses pthreads" *
audio/soundtracker/Makefile:# Uses pthreads
benchmarks/iozone/Makefile:# Uses pthreads
databases/mysql/Makefile:# Uses pthreads
devel/glib/Makefile:# Uses pthreads
devel/sdl/Makefile:# Uses pthreads
graphics/ggi/Makefile:# Uses pthreads
graphics/gii/Makefile:# Uses pthreads
lang/tcl/8.3/Makefile:# Uses pthreads (can but does not at the moment)
lang/tcl/8.4/Makefile:# Uses pthreads (can but does not at the moment)
net/mrtd/Makefile:# Uses pthreads
net/pdnsd/Makefile:# Uses pthreads
security/pcsc-lite/Makefile:# Uses pthreads

> - where is HOMEPAGE?

Added.

> - Missing: ltdl.4 (/usr/local/sbin/openct-control): NOT REACHABLE (make
> lib-depends-check). Hint: LIB_DEPENDS=ltdl.4::devel/libtool

OK.

> - please remove MESSAGE as it's really not needed and zap empty line
> from the end of pkg/DESCR

Done.

> > opensc-0.9.6
>
> - where is HOMEPAGE?

Added.

> - remove pkgconfig from you system and try to build opensc. See? It
> doesn't detect openct. Funny? Hint: Add pkgconfig to BUILD_DEPENDS

Oh, right.

> - pkg/MESSAGE is not needed
> - empty line at the end of pkg/DESCR

Done.
Thanks, diffs attached.

• text/x-patch attachment: diff.openct

• text/x-patch attachment: diff.opensc

• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]