OSEC

Neohapsis is currently accepting applications for employment. For more information, please visit our website www.neohapsis.com or email hr@neohapsis.com
 
Re: "Fuzzy" patching broken?

From: Ted Unangst (ted.unangstgmail.com)
Date: Fri Sep 01 2006 - 10:40:09 CDT


On 9/1/06, viq <vicviqgmail.com> wrote:
> On 9/1/06, Ted Unangst <ted.unangstgmail.com> wrote:
> > On 8/31/06, viq <vicviqgmail.com> wrote:
> > > On 8/31/06, Otto Moerbeek <ottodrijf.net> wrote:
> > > > Now I don't know if GNU patch has a more smart heuristic for this
> > > > case, but it could very well be just good luck GNU patch is appplying
> > > > the hunk at a better place, in this particluar case.
> > >
> > > Yes, GNU patch doesn't seem to have problems with this, while
> > > OpenBSD's does. So, a bug or a feature? Fix patch or fix patches? ;)
> >
> > so what happens when the last line that was added prior to the diff is
> > # EOF
> > ? where does gnu diff put the eof marker?
> >
>
> I'm not sure what you're asking here... If you mean where does the
> resulting file end, then GNU as last line has:
> $(LN_S) $(silc_top_srcdir)/lib/.libs/libsilcclient.a .libs/silcclient.a

i meant if "# EOF" was literally the last line. as in somebody added
it. based on your description, it seems gnu patch would leave that
line in the middle of the file. i'm referring to otto's "good luck"
comment.