From: Alexey Suslikov (alexey.suslikovgmail.com)
Date: Wed Nov 14 2007 - 15:50:03 CST

• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

Hello tech.

It is not proper to
   printf(" codecs; using %s\n", az->codecs[az->codecno].name);
if codec name is not set.

Before diff:
azalia0 at pci0 dev 27 function 0 "Intel 82801GB HD Audio" rev 0x02:
apic 2 int 21 (irq 10)
azalia0: Realtek/0x0861, Motorola/0x3055 codecs; using (null)
audio0 at azalia0

After diff:
azalia0 at pci0 dev 27 function 0 "Intel 82801GB HD Audio" rev 0x02:
apic 2 int 21 (irq 10)
azalia0: codecs 0: Realtek/0x0861 1: Motorola/0x3055; using codec 0
audio0 at azalia0

diff:

--- azalia.c.orig
+++ azalia.c
-677,8 +677,9
         /* Use the first audio codec */
         az->codecno = c;

- printf("%s:", XNAME(az));
+ printf("%s: codecs ", XNAME(az));
         for (i = 0; i < az->ncodecs; i++) {
+ printf("%d:", i);
                 if (az->codecs[i].name == NULL) {
                         vendor = pci_findvendor(az->codecs[i].vid >> 16);
                         if (vendor == NULL)
-691,9 +692,9
                 } else
                         printf(" %s", az->codecs[i].name);
                 if (i < az->ncodecs - 1)
- printf(",");
+ printf(" ");
         }
- printf(" codecs; using %s\n", az->codecs[az->codecno].name);
+ printf("; using codec %d\n", az->codecno);

         if (azalia_stream_init(&az->pstream, az, az->nistreams + 0,
             1, AUMODE_PLAY))

• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]