From: Claudio Jeker (cjekerdiehard.n-r-g.com)
Date: Sat Mar 01 2008 - 06:50:44 CST

• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

On Sat, Mar 01, 2008 at 12:06:00PM +0000, Stuart Henderson wrote:
> I'm attempting to port yongari's newer vr(4) driver from FreeBSD.
> So far I have mostly just reverted the style changes and re-ordered
> things so the diff has a better signal:noise ratio and just starting
> to change things to try and get it to build, I came across a few
> things so far which I wondered about:
>
> - what should I do with LOCK macros, just remove them?
>

Most probably you need splnet()/splx() calls as replacement (or probably a
splassert() to ensure correct spl levels). If you feel adventuresomely you
could use rwlocks and make dlg happy :)

> - there's one use of taskqueue which we don't have, do we have
> anything similar, any suggestions how to handle this?
>

Sounds like something similar to workq but not sure if I'm right.
Our workq may have different scheduling properties.
After glancing at the code -- the taskqueue is only used for mii link
checking -- I guess you can use a simple timeout callback for that.

> the code is here, http://spacehopper.org/vr/, it's not going to
> build anywhere just yet, and you can laugh at me if you like (-:
>

--
:wq Claudio

• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]