From: Mark Kettenis (mark.kettenisxs4all.nl)
Date: Sat Mar 01 2008 - 07:02:20 CST

• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

> Date: Sat, 1 Mar 2008 12:06:00 +0000
> From: Stuart Henderson <stuspacehopper.org>
>
> I'm attempting to port yongari's newer vr(4) driver from FreeBSD.
> So far I have mostly just reverted the style changes and re-ordered
> things so the diff has a better signal:noise ratio and just starting
> to change things to try and get it to build, I came across a few
> things so far which I wondered about:
>
> - what should I do with LOCK macros, just remove them?

If the section they appear in is protected by splnet(), probably yes.

Otherwise, you probably need to sprinkle in some splnet()/splx() pairs
yourself.

> - there's one use of taskqueue which we don't have, do we have
> anything similar, any suggestions how to handle this?

We have workq, but it's probably better to avoid this if you can?
What are the taskqueue's used for?

> the code is here, http://spacehopper.org/vr/, it's not going to
> build anywhere just yet, and you can laugh at me if you like (-:

Looking at the code, I'm fairly sure you're better of starting out
with the current OpenBSD driver and bringing in changes from the
FreeBSD driver after you have identified what the bits are that really
matter.

• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]