OSEC

Neohapsis is currently accepting applications for employment. For more information, please visit our website www.neohapsis.com or email hr@neohapsis.com
Re: pppctl cleanup

From: Karl Sjodahl - dunceor (dunceorgmail.com)
Date: Fri Aug 08 2008 - 03:39:46 CDT

On Thu, Aug 7, 2008 at 11:29 PM, Gleydson Soares <gsoaresgmail.com> wrote:
> this function don't return, void instead of int.
> Index: pppctl.c
> ===================================================================
> RCS file: /cvs/src/usr.sbin/ppp/pppctl/pppctl.c,v
> retrieving revision 1.19
> diff -u -r1.19 pppctl.c
> --- pppctl.c 26 Jul 2007 17:48:41 -0000 1.19
> +++ pppctl.c 7 Aug 2008 21:16:24 -0000
> -53,8 +53,8
> #define LINELEN 2048
> static char Buffer[LINELEN], Command[LINELEN];
>
> -static int
> -usage()
> +static void
> +usage(void)
> {
> fprintf(stderr, "usage: pppctl [-v] [-p passwd] [-t n] "
> "Port|LocalSock [command[;command]...]\n");
>
>

Why not mark it as __dead as they usually do in OpenBSD usage()?

BR
dunceor