OSEC

Neohapsis is currently accepting applications for employment. For more information, please visit our website www.neohapsis.com or email hr@neohapsis.com
Re: x264 diff for AltiVec/# CPUs detection

From: Brad (bradcomstyle.com)
Date: Mon Aug 25 2008 - 11:45:18 CDT


On Sun, 24 Aug 2008 23:21:10 +0200
Matthias Kilian <kilioutback.escape.de> wrote:

> On Sun, Aug 24, 2008 at 12:22:07AM -0400, Brad wrote:
> > The following diff for x264 switches the library from using
> > the signals method of AltiVec detection to using the sysctl
> > method and adds support for detecting the # of CPUs using
> > the sysctl.
>
> What's the correct way to test this? I tried
>
> $ ffmpeg -input foo.mpg -vcodec libx264 output.avi
>
> with and without the patch and didn't notice any performance
> improvement nor any (visible) output difference. If Altivec applies
> only to decoding, I've to do some more tests.
>
> And on arm, I get bus errors for the above command line regardless
> of what version fo x264 is used.
>
> Ciao,
> Kili

What you did above is correct. You will not notice any difference because
AltiVec was already enabled. This just changes the method used to detect
the presence of AltiVec.

--
This message has been scanned for viruses and
dangerous content by MailScanner, and is
believed to be clean.