Neohapsis is currently accepting applications for employment. For more information, please visit our website www.neohapsis.com or email firstname.lastname@example.org
From: Stuart Henderson (stuspacehopper.org)
Date: Sat Sep 11 2010 - 04:53:58 CDT
On 2010/09/11 09:40, Landry Breuil wrote:
> On Fri, Sep 10, 2010 at 09:59:56PM +0100, Tom Murphy wrote:
> > Hi all,
> > Attached is a diff to update net/libnice from 0.0.9 to 0.0.13. I
> > have tested it on i386 and amd64 and it compiles cleanly and installs.
> > However, only 2 of the 14 tests fail. I had been working with the
> > developer back when 0.0.9 was out to put some OpenBSD-friendly things
> > in, and he had. The GCC4 jump helped a lot so there are fewer patches
> > for this release. There are some warnings for duplicated functions
> > between some of the header files, but both header files appear to be
> > needed for it to compile.
> You should not remove the gcc-specific patches, as alpha and mips64el
> build this package, and they are still using gcc3..
> REVISION=0 is useless, and did you double check that library symbols
> didn't change ?
Not just the library symbols, it's important to check deeper than
this - the function parameters and sometimes return types can change,
e.g. this change was made in a previous clamav update, which AIUI
would require the major to be bumped.
-int cli_scanbuff(const unsigned char *buffer, uint32_t length, cli_ctx *ctx, cli_file_t ftype);
+int cli_scanbuff(const unsigned char *buffer, uint32_t length, uint32_t offset, cli_ctx *ctx, cli_file_t ftype, struct cli_ac_data **acdata);
Also sometimes structures are changed in ways which will cause
Some (very few) projects understand these issues and do their best
to avoid them, most don't (and then we also have the stupid things
like libraries named foo-2.0.so.0.0, foo-3.0.so.0.0 which means we
end up having to chase name changes through many ports...but that's
a different rant :-)
I usually find it's helpful to look through a diff of old and new
source trees (excluding configure scripts etc, and sometimes doing
a search-and-replace on the trees to mask out dates/version numbers
etc so they don't show up in the diff). I sometimes do this even if
no library is involved so I can get a feel for what's changed and
how safe it is to update.