OSEC

Neohapsis is currently accepting applications for employment. For more information, please visit our website www.neohapsis.com or email hr@neohapsis.com
Re: merge pms and pmsi + added support for some of mouse

From: Kenneth R Westerback (kwesterbackrogers.com)
Date: Mon Sep 27 2010 - 16:53:37 CDT

On Mon, Sep 27, 2010 at 08:28:36PM +0000, Miod Vallat wrote:
> > On Mon, Sep 27, 2010 at 10:42 AM, Alexandr Shadchin
> > <alexandr.shadchingmail.com> wrote:
> > > if (pa->pa_slot != PCKBC_AUX_SLOT)
> > > - return (0);
> > > + return 0;
> >
> > "return (x)" is proper KNF. Please don't undo it.
>
> Actually, return with braces is old KNF, just like K&R function
> declarations are. Developer taste change over time, and style(9) no
> longer says anything about return statements style.
>
> Miod

A sad reflection of the moral slackness of today's world. :-).

.... Ken