OSEC

Neohapsis is currently accepting applications for employment. For more information, please visit our website www.neohapsis.com or email hr@neohapsis.com
Re: merge pms and pmsi + added support for some of mouse

From: Mark Kettenis (mark.kettenisxs4all.nl)
Date: Tue Sep 28 2010 - 16:47:09 CDT

> Date: Wed, 29 Sep 2010 03:21:21 +0600
> From: Alexandr Shadchin <alexandr.shadchingmail.com>
>
> On Mon, Sep 27, 2010 at 01:10:58PM -0700, Matthew Dempsky wrote:
> > On Mon, Sep 27, 2010 at 10:42 AM, Alexandr Shadchin
> > <alexandr.shadchingmail.com> wrote:
> > > if (pa->pa_slot != PCKBC_AUX_SLOT)
> > > - return (0);
> > > + return 0;
> >
> > "return (x)" is proper KNF. Please don't undo it.
>
> I have recently seen more often return without the brackets, so I decided
> that this is correct. For me, with or without the brackets do not matter.
> So back braces or not?

I'd say, don't arbitrarily change them, and try to keep things
consistent with the code around it.