OSEC

Neohapsis is currently accepting applications for employment. For more information, please visit our website www.neohapsis.com or email hr@neohapsis.com
Re: cvsweb says 'No viewable change' for i915_drv.c diffs

From: Stuart Henderson (sthenopenbsd.org)
Date: Wed May 15 2013 - 05:53:45 CDT


On 2013/05/15 10:43, Alexey E. Suslikov wrote:
> Mark Kettenis <mark.kettenis <at> xs4all.nl> writes:
>
> > > Try this
> > >
> http://www.openbsd.org/cgi-bin/cvsweb/src/sys/dev/pci/drm/i915/i915_drv.c.diff?r1=1.26;r2=1.27;f=h
> > >
> > > and, for instance, this
> > >
> http://www.openbsd.org/cgi-bin/cvsweb/src/sys/dev/pci/drm/i915/i915_dma.c.diff?r1=1.6;r2=1.7;f=h
> > >
> > > Former says "No viewable change". I think it isn't normal. Am I wrong?
> >
> > Yes that's very annoying. I suspect cvsweb has problems with the UTF8
> > characters in the copyright header.
>
> cvsweb operates on individual diff chunks while preparing
> viewable output, right?
>
> if so, and you are right about UTF8, only one of these chunks
> is a showstopper.
>
> maybe cvsweb may say "No viewable change" for a problematic
> chunk only, instead of completely freaking out.
>

it's not cvsweb.

$ rcsdiff -u -r1.26 -r1.27 /cvs/src/sys/dev/pci/drm/i915/i915_drv.c,v
===================================================================
RCS file: /cvs/src/sys/dev/pci/drm/i915/i915_drv.c,v
retrieving revision 1.26
retrieving revision 1.27
diff -u -r1.26 -r1.27