OSEC

Neohapsis is currently accepting applications for employment. For more information, please visit our website www.neohapsis.com or email hr@neohapsis.com
 
From: Phil Pennock (Phil.Pennockglobnix.org)
Date: Wed Aug 08 2001 - 22:07:03 CDT

  • Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

    On 2001-08-08 at 18:03 -0600, Todd C. Miller wrote:
    > CVSROOT: /cvs
    > Module name: src
    > Changes by: millertcvs.openbsd.org 2001/08/08 18:03:12
    >
    > Modified files:
    > bin/ln : ln.1 ln.c
    >
    > Log message:
    > Add -h flag to prevent following a symlink to a dir as the dest.
    > Also add -n as an alias for -h for compat with GNU ln.
    > Patch from Phil.Pennockglobnix.org with minor changes by me.

    *coughs*

    Erm, you applied all the bits which lay the structure for the change,
    but don't actually _use_ the change.

    The next call to stat() after "statf = hflag ? lstat : stat;" needs to
    change to use statf instead.

    <pedant>
    Also, whilst you did what I did for the manual-page, and only changed
    the first synopsis usage, you changed both lines of output from usage().
    </pedant>

    Good to see the other cleanups too though. :^) 

    -- 
"Before you dig in, I'd like to read the ingredients to you."
"Uh-oh... collateral damage to the conscience."
 - <http://www.schlockmercenary.com/d/20010225.html>