From: Miod Vallat (miodcvs.openbsd.org)
Date: Wed Jun 20 2007 - 15:13:41 CDT

• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

CVSROOT: /cvs
Module name: src
Changes by: miodcvs.openbsd.org 2007/06/20 14:13:41

Modified files:
        sys/arch/hp300/dev: hd.c
        sys/arch/vax/vsa: hdc9224.c

Log message:
These drivers were abusing b_cylinder to store device-specific information
in strategy(), and were reusing it in start().
I first considered introducing a b_rawblkno field in struct buf, as has been
done in NetBSD, to stop this abuse.
However, it does not cost more to simply move the device-specific
``was-b_cylinder'' computation to the start() routine. Plus we get type fixes
(daddr64_t) for free, although this does not really matter for these
pedro-sized devices. Thus we do not need to grow struct buf for these
devices which really ought to live in your Attic (and my machineroom, of
course).

hp300 HP-IB tested, vax mfm not, but the logic is the same.

• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]