OSEC

Neohapsis is currently accepting applications for employment. For more information, please visit our website www.neohapsis.com or email hr@neohapsis.com
Re: CVS: cvs.openbsd.org: src

From: Damien Miller (djmmindrot.org)
Date: Mon Oct 06 2008 - 23:36:00 CDT


On Mon, 6 Oct 2008, Marc Espie wrote:

> CVSROOT: /cvs
> Module name: src
> Changes by: espiecvs.openbsd.org 2008/10/06 03:36:17
>
> Modified files:
> usr.sbin/pkg_add: pkg_create pkg_merge
> usr.sbin/pkg_add/OpenBSD: Add.pm CollisionReport.pm Delete.pm
> PackingElement.pm PackingList.pm
> md5.pm
>
> Log message:
> turn the checksums stored in packing elements into real objects, so that
> pkg_add becomes mostly independent of the type of checksum stored.
>
> separate md5 into an abstract OpenBSD::digest class and an md5 subclass
> with specific methods to compute checksums and serialize results, and create
> an sha class that does the same thing with sha256 (with a base64 serializer)

This breaks upgrades for me:

===> Updating for png-1.2.32
Upgrading from png-1.2.28
Can't locate object method "compute_md5" via package "OpenBSD::PackingElement::FDESC" at /usr/libdata/perl5/OpenBSD/Replace.pm line 455.
*** Error code 22

Stop in /usr/ports/graphics/png (line 1474 of /usr/ports/infrastructure/mk/bsd.port.mk).

It dies fairly hard, leaving a broken /var/db/pkg/.libs-png-1.2.28 directory
with a +DESCR but no +CONTENTS that has to be cleaned up manually.

-d