Re: [PATCH] to INSTALL.sh to ensure successful completion returns 0

Wietse Venema (wietseporcupine.org)
Mon, 22 Nov 1999 18:38:16 -0500 (EST)

• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
• Next message: Wietse Venema: "Re: USE THIS PATCH INSTEAD (Re: (LONG) LDAP and bogus characters)"
• Previous message: sadiego2.pl: "ldap vs mysql lookups"
• Next in thread: Simon J Mudd: "Re: [PATCH] to INSTALL.sh to ensure successful completion returns 0"
• Reply: Simon J Mudd: "Re: [PATCH] to INSTALL.sh to ensure successful completion returns 0"

I have re-vamped main.cf considerably, including support for
install_root. I'm about to release a new code snapshot.

        Wietse

Simon J Mudd:
> Wietse,
>
> I think running INSTALL.sh always returns 1. This has an unfortunate
> effect if the scripts calling it assume this is an error condition.
>
> Would you accept this trivial patch which ensures that if installation is
> successfull the return value of the script is 0?
>
> --- postfix-19990906-pl07/INSTALL.sh.p3 Sat Nov 13 18:57:20 1999
> +++ postfix-19990906-pl07/INSTALL.sh Mon Nov 22 23:54:09 1999
> -7,7 +7,8
> umask 022
>
> # Workaround, should edit main.cf in place.
> -trap 'rm -f ./main.cf; exit 1' 0 1 2 3 15
> +trap 'rm -f ./main.cf; exit 0' 0
> +trap 'rm -f ./main.cf; exit 1' 1 2 3 15
>
> cat <<EOF
>
> --------------------------------------------------
>
> Regards,
>
> Simon
> --
> Simon J Mudd, Madrid SPAIN Tel: +34-91-408 4878 email: sjmuddpobox.com
>
>
>
>

• Next message: Wietse Venema: "Re: USE THIS PATCH INSTEAD (Re: (LONG) LDAP and bogus characters)"
• Previous message: sadiego2.pl: "ldap vs mysql lookups"
• Next in thread: Simon J Mudd: "Re: [PATCH] to INSTALL.sh to ensure successful completion returns 0"
• Reply: Simon J Mudd: "Re: [PATCH] to INSTALL.sh to ensure successful completion returns 0"

This archive was generated by hypermail 2.0b3 on Mon Nov 22 1999 - 17:42:10 CST