Re: USE THIS PATCH INSTEAD (Re: (LONG) LDAP and bogus characters)

Wietse Venema (wietseporcupine.org)
Mon, 22 Nov 1999 18:44:43 -0500 (EST)

• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
• Next message: Craig Sanders: "Re: Which is better? Postfix, qmail, exim or zmailer ?"
• Previous message: Wietse Venema: "Re: [PATCH] to INSTALL.sh to ensure successful completion returns 0"
• In reply to: Simon J Mudd: "[PATCH] to INSTALL.sh to ensure successful completion returns 0"
• Next in thread: Keith Stevenson: "Re: LDAP patch"
• Reply: Keith Stevenson: "Re: LDAP patch"

I've adopted this patch with one change:

- in addition to escaping * in search keys, the code now also
  escapes the \ escape character itself.

This is because the problem report was with lookups of keys consisting
of a stray \ character.

        Wietse

John Hensley wrote:
> Good morning all,
>
> The previous patch was bogus; removing the msg_fatal() on a failed
> ldap_search_st() exposed a bug in the decision to cleanup, and
> dict_errno wouldn't get set, so the lookup would act as if nothing were
> found, not as if there were a problem, so for example local deliveries
> would bounce instead of being deferred. This version fixes that, and
> I've also replaced the other msg_fatal() calls in dict_ldap_lookup(). In
> the testing I could get done this morning, failures at those points
> bubble up into dict_open, which still ends up calling msg_fatal, but
> with a more informative format. And then tag, Wietse's it, and the LDAP
> module is now robust. Right, Wietse? :^\
>
> Sorry for the flailing. This code could really use a maintainer with
> more time.
>
> John

• Next message: Craig Sanders: "Re: Which is better? Postfix, qmail, exim or zmailer ?"
• Previous message: Wietse Venema: "Re: [PATCH] to INSTALL.sh to ensure successful completion returns 0"
• In reply to: Simon J Mudd: "[PATCH] to INSTALL.sh to ensure successful completion returns 0"
• Next in thread: Keith Stevenson: "Re: LDAP patch"
• Reply: Keith Stevenson: "Re: LDAP patch"

This archive was generated by hypermail 2.0b3 on Mon Nov 22 1999 - 17:46:31 CST