From: Keean Schupke (keeanfry-it.com)
Date: Sat Dec 01 2007 - 16:43:53 CST

• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

Hi,

>
> Actually, the alldig() is probably enough, missed that test. Testing
> the validity of the DSN ([45].X.Y) string is likely still a good idea.
>

have added a dsn_valid() check, and swapped to using strtoul, along
with unsigned long for all time values... no negative times.

> > > > + smtp_sasl_make_cache_key(buf, session->host,
> > > > +}
> > >
> > > With SASL soft failures, the DSN should perhaps be downgraded from 5XX
> > > to 4XX here? And validated somewhere to be either a 5XX or 4XX?
> > >
> >
> > The downgrading happens automatically, the cache_update happens after
> > the resp->dsn has been changed by the soft_bounce patch. So no need to
> > alter things on the query side.
>
> OK, but the value from the cache may have been from a time with different
> settings, so the cache results may need downgrading.

Okay, will cache the real return value, and do downgrading on read.

Regards,
Keean Schupke, Fry-IT Ltd.

• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]