From: Victor Duchovni (Victor.Duchovnimorganstanley.com)
Date: Fri May 16 2008 - 10:14:21 CDT

• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

On Fri, May 16, 2008 at 04:08:22PM +0900, YOSHIMURA Keitaro wrote:

> The handling of the bounce_size_limit parameter is amusing.

In what way is it "amusing"? Please describe your use case.

> The hot fix was made and look, please.

Zero means "no limit". The patch breaks this (though in practice main.cf
settings are restricted to >= 1, so this breaks a use case that is
currently disabled).

> --- postfix-2.4.6.orig/src/bounce/bounce_notify_util.c 2006-07-05 07:43:16.000000000 +0900
> +++ postfix-2.4.6/src/bounce/bounce_notify_util.c 2008-05-15 18:20:34.000000000 +0900
> -736,10 +736,10
> */
> - if (var_bounce_limit > 0
> - && bounce_info->orig_fp
> - && (bounce_info->message_size <= 0
> - || bounce_info->message_size > var_bounce_limit))
> + if (var_bounce_limit <= 0
> + || bounce_info->orig_fp == 0
> + || bounce_info->message_size <= 0
> + || bounce_info->message_size > var_bounce_limit)
> headers_only = DSN_RET_HDRS;

--
        Viktor.

Disclaimer: off-list followups get on-list replies or get ignored.
Please do not ignore the "Reply-To" header.

To unsubscribe from the postfix-users list, visit
http://www.postfix.org/lists.html or click the link below:
<mailto:majordomopostfix.org?body=unsubscribe%20postfix-users>

If my response solves your problem, the best way to thank me is to not
send an "it worked, thanks" follow-up. If you must respond, please put
"It worked, thanks" in the "Subject" so I can delete these quickly.

• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]