OSEC

Neohapsis is currently accepting applications for employment. For more information, please visit our website www.neohapsis.com or email hr@neohapsis.com
valid_hostname chokes on trailing dot

From: Chad Whitacre (chadzetaweb.com)
Date: Wed Oct 01 2008 - 10:35:18 CDT

Greetings,

In src/util/valid_hostname.c (version 2.5.5), valid_hostname
gives a "misplaced delimiter" warning if the hostname ends in a
trailing dot. Since a trailing dot is technically part of a FQDN,
I suggest that valid_hostname allow them. Patch attached.

chad

P.S. New to postfix, couldn't find any version control from the
  website, hence the patch against 2.5.5. The bug also exists in
  2.6-20080903.

--- src/util/valid_hostname.c.orig Wed Oct 1 15:07:15 2008
+++ src/util/valid_hostname.c Wed Oct 1 15:07:20 2008
-109,7 +109,7
             if (!ISDIGIT(ch))
                 non_numeric = 1;
         } else if (ch == '.') {
- if (label_length == 0 || cp[1] == 0) {
+ if (label_length == 0) {
                 if (gripe)
                     msg_warn("%s: misplaced delimiter: %.100s", myname, name);
                 return (0);